les: simplify prenegfilter #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
simplify-prenegfilter
branch
from
73c86c6
to
8941a89
Compare
zsfelfoldi
requested changes
May 12, 2020
There was a problem hiding this comment.
I think we do need the cancel callback provided by PreNegQuery which you removed in this PR. Sure, the filter and the test can work fine without it, the reason for this callback is that the actual UDP implementation needs it (you can find it in my les4 PR). UDP uses reply hash ids and the query implementation maps handlers to hashes after sending the request. The cancel callback removes the mapping so the reply is no longer expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
prenegfilterwaitingset byprenegfilteritself.In the original implementation, we decrease the
canDialCounteronly when the tag is removed.In another word, the internal counter depends on the external system. It's not a good idea to do it.
needQueries<pending. In the original implementation, actually there is only one live query each time